July 2004 Commit Log

« Development Statistics for /trunk/Drivers/ccid

Commit Logs

Number of Commits:: 63
Number of Active Developers:: 1

rousseau 2004-07-28 10:36 #63 Rev.: 1107

use reader_index instead of lun as reader identification
allocate (in IFDHCreateChannel*) and release (in IFDHCloseChannel)

78 lines of code changed in 1 file:

src: ifdhandler.c (+78 -54)

rousseau 2004-07-28 10:33 #62 Rev.: 1106

use reader_index instead of lun as reader identification

188 lines of code changed in 9 files:

src: ccid.c (+5 -5), ccid.h (+2 -2), ccid_ifdhandler.h (+1 -1), ccid_serial.c (+44 -41), ccid_serial.h (+7 -7), ccid_usb.c (+52 -50), ccid_usb.h (+7 -5), commands.c (+55 -51), commands.h (+15 -12)

rousseau 2004-07-28 10:30 #61 Rev.: 1105

use a more complex Lun -> reader transformation
(Lun>>16) is not usable for multi-slots readers

39 lines of code changed in 2 files:

src: utils.c (+34 -8), utils.h (+5 -4)

rousseau 2004-07-27 08:42 #60 Rev.: 1103

this code fails EMV test 1771-4 (should be a residue)

8 lines of code changed in 1 file:

src/openct: proto-t1.c (+8 -18)

rousseau 2004-07-26 15:41 #59 Rev.: 1102

- debug some cases
- add ISO 7816-3 rule number in comments

48 lines of code changed in 1 file:

src/openct: proto-t1.c (+48 -9)

rousseau 2004-07-26 11:16 #58 Rev.: 1101

initialise ccid.defaultFeatures field

2 lines of code changed in 2 files:

src: ccid_serial.c (+1), ccid_usb.c (+1 -1)

rousseau 2004-07-22 12:01 #57 Rev.: 1096

use pkg-config to test the release version of pcsc-lite

7 lines of code changed in 1 file:

configure.in (+7 -1)

rousseau 2004-07-21 11:04 #56 Rev.: 1095

version 0.9.2

1 lines of code changed in 1 file:

configure.in (+1 -1)

rousseau 2004-07-21 11:02 #55 Rev.: 1094

hack to support the SCR331-DI contactless interface

48 lines of code changed in 1 file:

src: ifdhandler.c (+48)

rousseau 2004-07-21 11:01 #54 Rev.: 1093

ccid_open_hack(): detect and activate the contactless interface of the
SCR331-DI

30 lines of code changed in 1 file:

src: ccid.c (+30)

rousseau 2004-07-21 11:00 #53 Rev.: 1092

use bCurrentSlotIndex as the slot number in the CCID commands (instead of 0)

7 lines of code changed in 1 file:

src: commands.c (+7 -7)

rousseau 2004-07-21 10:59 #52 Rev.: 1091

initialise bMaxSlotIndex and ccid.bCurrentSlotIndex fields

4 lines of code changed in 2 files:

src: ccid_serial.c (+2), ccid_usb.c (+2)

rousseau 2004-07-21 10:56 #51 Rev.: 1090

add defaultFeatures field for multislot readers with different
dwFeatures for each slot.

6 lines of code changed in 1 file:

src: ccid.h (+6)

rousseau 2004-07-21 10:56 #50 Rev.: 1089

add SCR331DI identification

1 lines of code changed in 1 file:

src: ccid.h (+1)

rousseau 2004-07-21 10:55 #49 Rev.: 1088

add bMaxSlotIndex and bCurrentSlotIndex fields to support multislot
readers (one USB device with two or more card readers)

10 lines of code changed in 1 file:

src: ccid.h (+10)

rousseau 2004-07-20 11:19 #48 Rev.: 1087

remove "|| sent_length" in "if (retries == 0 || sent_length)" since it
is an OpenCT code that should not be needed with the new automata.

1 lines of code changed in 1 file:

src/openct: proto-t1.c (+1 -1)

rousseau 2004-07-20 11:16 #47 Rev.: 1086

update the copyright, add my name to reflect the same change in OpenCT

3 lines of code changed in 1 file:

src/openct: proto-t1.c (+3)

rousseau 2004-07-19 16:58 #46 Rev.: 1085

update IFDHControl() prototype to replace LPVOID by PUCHAR (prototype
changed in pcsc-lite-1.2.9-beta5)

2 lines of code changed in 1 file:

src: ifdhandler.c (+2 -2)

rousseau 2004-07-19 15:32 #45 Rev.: 1084

BUG: I forgot to initialise the t1.lun field. It failed to work with
more than one readers and a T=1 card in a TPDU reader.

5 lines of code changed in 3 files:

src: ifdhandler.c (+1 -1)
src/openct: proto-t1.c (+3 -1), proto-t1.h (+1 -1)

rousseau 2004-07-19 11:36 #44 Rev.: 1083

in resync: we set retries = 1 since when we return in the loop we have
retries--;
Without this retries goes negative and the test 'if (retries == 0)' will
not become true again before a looooong time.

1 lines of code changed in 1 file:

src/openct: proto-t1.c (+1)

rousseau 2004-07-16 11:07 #43 Rev.: 1079

OpenUSBByName(): use base 0 instead of 16 in strtoul() so that you can
express the decimal value 15 as: 15 (decimal), 0xF (hex) or 017 (octal).

It is not really needed since the reader descriptions in Info.plist are
all in hex.

2 lines of code changed in 1 file:

src: ccid_usb.c (+2 -2)

rousseau 2004-07-16 09:06 #42 Rev.: 1078

init_driver(): use base 0 instead of 16 in strtoul() so that you can
express the decimal value 15 as: 15 (decimal), 0xF (hex) or 017 (octal)

2 lines of code changed in 1 file:

src: ifdhandler.c (+2 -2)

rousseau 2004-07-16 08:53 #41 Rev.: 1077

rename PCSCLITE_MAX_READERS in CCID_DRIVER_MAX_READERS

This value is not defined by pcsc-lite but is internal to the CCID
driver. By default pcsc-lite supports the same number of readers (16).

13 lines of code changed in 6 files:

src: ccid_ifdhandler.h (+4 -1), ccid_serial.c (+2 -2), ccid_usb.c (+3 -3), ifdhandler.c (+2 -2), parse.c (+1 -1), utils.c (+1 -1)

rousseau 2004-07-16 08:31 #40 Rev.: 1076

BUG: CmdPowerOn(): use memmove() instead of memcpy() to copy the ATR
bytes since the source end destination buffers (with a more than 10
bytes long ATR) overlaps.

Bug spotted by splint http://www.splint.org/

1 lines of code changed in 1 file:

src: commands.c (+1 -1)

rousseau 2004-07-15 16:52 #39 Rev.: 1075

use "uint8_t *" instead of "unsigned char *" in the prototype of
t1_state_t.checksum field.

2 lines of code changed in 1 file:

src/openct: proto-t1.h (+2 -2)

rousseau 2004-07-15 16:51 #38 Rev.: 1074

initialise pcDesiredKey to NULL instead of 0

1 lines of code changed in 1 file:

src: tokenparser.l (+1 -1)

rousseau 2004-07-15 16:08 #37 Rev.: 1073

BUG in CmdXfrBlockTPDU_T1(): the t1_transceive() returned value was
stored in an unsigned int and tested if < 0 (error case). Of course the
test was never true.

5 lines of code changed in 1 file:

src: commands.c (+5 -2)

rousseau 2004-07-15 11:31 #36 Rev.: 1071

remove a useless break; after a goto;

0 lines of code changed in 1 file:

src/openct: proto-t1.c (-1)

rousseau 2004-07-15 11:19 #35 Rev.: 1070

in t1_transceive() and t1_negociate_ifsd() dad argument is unsigned.

4 lines of code changed in 2 files:

src/openct: proto-t1.c (+2 -2), proto-t1.h (+2 -2)

rousseau 2004-07-15 11:11 #34 Rev.: 1069

replace "unsigned char *" by "uint8_t *" to use the exact same prototype as in
the functions definition

3 lines of code changed in 1 file:

src/openct: checksum.h (+3 -2)

rousseau 2004-07-15 10:48 #33 Rev.: 1068

i2dw() is not used outside commands.c so declare it static

3 lines of code changed in 2 files:

src: commands.c (+3 -1), commands.h (-2)

rousseau 2004-07-15 10:45 #32 Rev.: 1067

allow splint to continue parsing after use of type fd_set

2 lines of code changed in 1 file:

examples: scardcontrol.c (+2)

rousseau 2004-07-15 10:33 #31 Rev.: 1066

CmdXfrBlockTPDU_T0() and CmdXfrBlockTPDU_T1() are internal functions so
declare them static

12 lines of code changed in 2 files:

src: commands.c (+12 -2), commands.h (-8)

rousseau 2004-07-15 10:30 #30 Rev.: 1065

atr tables are internal only so declare them static

3 lines of code changed in 1 file:

src/towitoko: atr.c (+3 -3)

rousseau 2004-07-15 10:24 #29 Rev.: 1064

define internal functions as static

7 lines of code changed in 1 file:

src/openct: proto-t1.c (+7 -7)

rousseau 2004-07-15 09:26 #28 Rev.: 1063

remove unused functions

0 lines of code changed in 2 files:

src/openct: buffer.c (-96), buffer.h (-9)

rousseau 2004-07-10 15:46 #27 Rev.: 1062

change "previous_block[1]" in "previous_block[PCB]"

6 lines of code changed in 1 file:

src/openct: proto-t1.c (+6 -6)

rousseau 2004-07-10 15:32 #26 Rev.: 1061

remove unused struct ifd_protocol_ops

0 lines of code changed in 1 file:

src/openct: proto-t1.c (-19)

rousseau 2004-07-10 15:23 #25 Rev.: 1060

IFD_PROTOCOL_MORE -> IFD_PROTOCOL_T1_MORE
IFD_PROTOCOL_STATE -> IFD_PROTOCOL_T1_STATE
renamed to be in line with OpenCT

6 lines of code changed in 2 files:

src/openct: proto-t1.c (+4 -4), proto-t1.h (+2 -2)

rousseau 2004-07-09 16:08 #24 Rev.: 1059

explicitely cast the returned value as (void) if we don't use it

4 lines of code changed in 3 files:

examples: scardcontrol.c (+1 -1)
src: ifdhandler.c (+2 -2), parse.c (+1 -1)

rousseau 2004-07-09 16:06 #23 Rev.: 1058

IFDHSetProtocolParameters(): test the return value of SetParameters()

4 lines of code changed in 1 file:

src: ifdhandler.c (+4 -2)

rousseau 2004-07-09 15:29 #22 Rev.: 1057

ccid_parse_interface_descriptor() is now static

2 lines of code changed in 1 file:

src: parse.c (+2 -2)

rousseau 2004-07-09 15:27 #21 Rev.: 1056

make channel variable (unsigned int) instead of (int)

2 lines of code changed in 1 file:

src: parse.c (+2 -2)

rousseau 2004-07-09 15:25 #20 Rev.: 1055

include <sys/types.h> so splint can parse the file

3 lines of code changed in 1 file:

src: parse.c (+3)

rousseau 2004-07-09 15:23 #19 Rev.: 1054

mark potentially null values as /*@null@*/ for splint

5 lines of code changed in 3 files:

src: ccid_serial.c (+1 -1), ccid_usb.c (+2 -2), ccid_usb.h (+2 -2)

rousseau 2004-07-09 15:21 #18 Rev.: 1053

mark unused arguments as /*@unused@*/ for splint

7 lines of code changed in 5 files:

src: ccid_serial.c (+2 -1), ccid_usb.c (+1 -1), ifdhandler.c (+2 -2), parse.c (+1 -1)
src/openct: proto-t1.c (+1 -1)

rousseau 2004-07-09 15:19 #17 Rev.: 1052

include <sys/types.h> so splint can parse the file

3 lines of code changed in 1 file:

src: ccid_usb.c (+3)

rousseau 2004-07-09 10:45 #16 Rev.: 1051

the buffer var_text[] was, in fact, used outside its declaration

1 lines of code changed in 1 file:

src: ccid.c (+1 -2)

rousseau 2004-07-09 10:40 #15 Rev.: 1050

ReadChunk() and get_bytes() are internal use in ccid_serial.c so declare
them static

9 lines of code changed in 2 files:

src: ccid_serial.c (+9 -1), ccid_serial.h (-5)

rousseau 2004-07-09 10:28 #14 Rev.: 1049

lun is (unsigned int) so reader = LunToReaderIndex(lun) is also (unsigned int)

6 lines of code changed in 2 files:

src: ccid_serial.c (+2 -2), ccid_usb.c (+4 -4)

rousseau 2004-07-09 10:25 #13 Rev.: 1048

OpenSerialByName(): arguments of CmdEscape() are unsigned

3 lines of code changed in 1 file:

src: ccid_serial.c (+3 -3)

rousseau 2004-07-09 10:22 #12 Rev.: 1047

replace "121234" by "123456" to make it more clear it is a memory reservation
for 6 characters

2 lines of code changed in 1 file:

src: ccid_serial.c (+2 -2)

rousseau 2004-07-09 10:21 #11 Rev.: 1046

remove a unneeded cast in (int)lun

1 lines of code changed in 1 file:

src: ccid_serial.c (+1 -1)

rousseau 2004-07-09 10:18 #10 Rev.: 1045

allow splint to continue parsing after use of type fd_set

2 lines of code changed in 1 file:

src: ccid_serial.c (+2)

rousseau 2004-07-09 10:11 #9 Rev.: 1044

ReadSerial(): the unknown card movement byte is in "c" not "buffer[3]"

1 lines of code changed in 1 file:

src: ccid_serial.c (+1 -1)

rousseau 2004-07-09 09:10 #8 Rev.: 1043

lun is (unsigned int) instead of (int)

Avoid a warning by splint in #define LunToReaderIndex(Lun) (Lun>>16)
Left operand of >> may be negative (int): lun >> 16

79 lines of code changed in 10 files:

src: ccid.c (+1 -1), ccid.h (+2 -2), ccid_ifdhandler.h (+1 -1), ccid_serial.c (+9 -9), ccid_serial.h (+16 -7), ccid_usb.c (+6 -6), ccid_usb.h (+10 -5), commands.c (+12 -11), commands.h (+21 -11), ifdhandler.c (+1 -1)

rousseau 2004-07-02 16:12 #7 Rev.: 1023

replace VENDOR pattern by MAGIC_VENDOR since we also have a VENDOR in
IOCTL_SMARTCARD_VENDOR_IFD_EXCHANGE and then a collision.

same change for PRODUCT and FRIENDLYNAME to be homogenous.

6 lines of code changed in 2 files:

src: Info.plist (+3 -3), create_Info_plist.pl (+3 -3)

rousseau 2004-07-02 15:58 #6 Rev.: 1022

OpenSerialByName(): perform a command (get the reader firmware) to be
sure a GemPC Twin (serial or pcmcia) reader is connected

20 lines of code changed in 1 file:

src: ccid_serial.c (+20)

rousseau 2004-07-02 14:06 #5 Rev.: 1021

present where the files come from and what I did

7 lines of code changed in 1 file:

src/openct: README (new 7)

rousseau 2004-07-01 13:42 #4 Rev.: 1019

version 0.9.1

1 lines of code changed in 1 file:

configure.in (+1 -1)

rousseau 2004-07-01 13:38 #3 Rev.: 1018

release 0.9.1

3 lines of code changed in 1 file:

README (+3)

rousseau 2004-07-01 13:37 #2 Rev.: 1017

#define IFD_PARITY_ERROR

4 lines of code changed in 1 file:

src/openct: proto-t1.h (+4)

rousseau 2004-07-01 09:46 #1 Rev.: 1015

release 0.9.0

44 lines of code changed in 1 file:

README (+44 -1)

June 2004 »

Generated by StatSVN 0.7.0