August 2010 Commit Log

Number of Commits:

53

Number of Active Developers:

1

rousseau 2010-08-31 10:34 #53 Rev.: 5204

Reformat

4 lines of code changed in 1 file:

• src: eventhandler.c (+4 -8)

rousseau 2010-08-30 15:27 #52 Rev.: 5202

InitializeSocket(): do not set the execution bit on the socket file. It
is useless.

1 lines of code changed in 1 file:

• src: winscard_msg_srv.c (+1 -1)

rousseau 2010-08-27 14:52 #51 Rev.: 5196

svn propset svn:keywords 'Author Date Id Revision'

4 lines of code changed in 4 files:

• src: debug.c (+1 -1), error.c (+1 -1), utils.c (+1 -1), utils.h (+1 -1)

rousseau 2010-08-27 14:48 #50 Rev.: 5195

GetDaemonPid(): use open(3) instead of fopen(3) to avoid an internal
malloc() call and gain some CPU cycles

5 lines of code changed in 1 file:

• src: utils.c (+5 -5)

rousseau 2010-08-27 14:24 #49 Rev.: 5194

HPAddDevice(): wait 1 millisecond instead of 1 second until the device
is visible to libusb/etc.

1 lines of code changed in 1 file:

• src: hotplug_libhal.c (+1 -1)

rousseau 2010-08-25 10:32 #48 Rev.: 5183

Doxygen: SCardCheckDaemonAvailability() do not invalidate handles after
a fork() any more

3 lines of code changed in 1 file:

• src: winscard_clnt.c (+3 -4)

rousseau 2010-08-23 12:25 #47 Rev.: 5179

HPReadBundleValues(): use the new Info.plist parsing API.

Parsing the CCID Info.plist (159 readers supported) was on a ARM9
machine 13193049 �s and is now 258262 �s => gain x51 or 5008%

50 lines of code changed in 1 file:

• src: hotplug_libusb.c (+50 -47)

rousseau 2010-08-23 11:49 #46 Rev.: 5178

RFBindFunctions(): rename rv in rvl to avoid warnings
warning: declaration of �rv� shadows a previous local

Also change type from DWORD to int since DYN_GetAddress() returns an int

6 lines of code changed in 1 file:

• src: readerfactory.c (+6 -6)

rousseau 2010-08-23 11:46 #45 Rev.: 5177

RFLoadReader(): optimize the detection of Ifd Handler version by
checking for "IFDHCreateChannelByName", "IFDHCreateChannel" and then
"IO_Create_Channel" instead of the 3 symbols at once.

Also suppress the error message suppression. Ifd handler v2 or v1 will
display one or two errors for symbols not found.

24 lines of code changed in 1 file:

• src: readerfactory.c (+24 -28)

rousseau 2010-08-23 10:53 #44 Rev.: 5175

HPReadBundleValues(): duplicate the readerName and CFBundleName strings
since the originals are destroyed by bundleRelease() later

The reader names were corrupted.

2 lines of code changed in 1 file:

• src: hotplug_libhal.c (+2 -2)

rousseau 2010-08-18 23:25 #43 Rev.: 5160

Fix typo

1 lines of code changed in 1 file:

• ChangeLog (+1 -1)

rousseau 2010-08-17 16:48 #42 Rev.: 5157

HPReadBundleValues(): use the new Info.plist parsing API.

Parsing the CCID Info.plist (159 readers supported) was on a i386
machine 264306 �s and is now 5547 �s => gain x47 or 4600%

54 lines of code changed in 1 file:

• src: hotplug_libhal.c (+54 -51)

rousseau 2010-08-17 16:41 #41 Rev.: 5156

parse the Info.plist file only once and generate a list of key/values

147 lines of code changed in 2 files:

• src: parser.h (+9 -9), tokenparser.l (+138 -86)

rousseau 2010-08-17 11:13 #40 Rev.: 5152

HPSearchHotPluggables(): create the synchronisation pipe only if the
HPEstablishUSBNotifications thread is created.
Avoids to leak resources.

9 lines of code changed in 1 file:

• src: hotplug_libusb.c (+9 -8)

rousseau 2010-08-17 11:10 #39 Rev.: 5151

HPSearchHotPluggables(): wait for initial readers to setup only if
HPEstablishUSBNotifications is created. Otherwise the process is
blocked for ever.

5 lines of code changed in 1 file:

• src: hotplug_libusb.c (+5 -3)

rousseau 2010-08-17 10:58 #38 Rev.: 5150

HPRegisterForHotplugEvents(): having no bundle for USB readers is not an
error. USB support/hotplug is just disabled.

1 lines of code changed in 1 file:

• src: hotplug_libhal.c (+1 -1)

rousseau 2010-08-17 10:56 #37 Rev.: 5149

main(): Log a message if HPRegisterForHotplugEvents() fails

3 lines of code changed in 1 file:

• src: pcscdaemon.c (+3)

rousseau 2010-08-17 08:41 #36 Rev.: 5148

Do not hardcode the libusb-1.0 include header path (remove the
libusb-1.0/ part)

1 lines of code changed in 1 file:

• src: hotplug_libusb.c (+1 -1)

rousseau 2010-08-16 16:40 #35 Rev.: 5147

Do not hardcode the libusb.h path.

See Debian bug #591782
ccid: FTBFS on kfreebsd-*: configure: error: libusb.h not found

1 lines of code changed in 1 file:

• configure.in (+1 -1)

rousseau 2010-08-16 16:28 #34 Rev.: 5146

add --sysconfdir=/etc

1 lines of code changed in 1 file:

• c.sh (+1)

rousseau 2010-08-16 12:03 #33 Rev.: 5145

Do not allow restricting defaults values of --max-thread,
--max-card-handle-per-thread or --max-card-handle-per-reader when
restricted

6 lines of code changed in 1 file:

• src: pcscdaemon.c (+6)

rousseau 2010-08-16 11:47 #32 Rev.: 5144

Do not allow APDU logging when restricted

5 lines of code changed in 1 file:

• src: pcscdaemon.c (+5)

rousseau 2010-08-16 11:45 #31 Rev.: 5143

If the process is setuid or setgid it may have some restrictions

Do not allow to specify a configuration file when restricted

9 lines of code changed in 1 file:

• src: pcscdaemon.c (+9)

rousseau 2010-08-15 20:48 #30 Rev.: 5138

release 1.6.4

9 lines of code changed in 2 files:

• ChangeLog (+8), configure.in (+1 -1)

rousseau 2010-08-15 20:43 #29 Rev.: 5137

Do not use sysconfdir as configuration directory but
${sysconfdir}/reader.conf.d instead.

Use --enable-confdir=DIR if you want to set a specific value without the
reader.conf.d appended.

Thanks to Kalev Lember for the bug report
http://archives.neohapsis.com/archives/dev/muscle/2010-q3/0150.html

8 lines of code changed in 1 file:

• configure.in (+8 -12)

rousseau 2010-08-15 17:39 #28 Rev.: 5135

release 1.6.3

12 lines of code changed in 2 files:

• ChangeLog (+11), configure.in (+1 -1)

rousseau 2010-08-15 16:48 #27 Rev.: 5134

Define LPSCARD_READERSTATE since this is used in the MSDN prototype.

Use LPSCARD_READERSTATE in winscard.h instead of (SCARD_READERSTATE *)
to mimic the MSDN API.

This partly reverts changeset 5096

2 lines of code changed in 2 files:

• src/PCSC: pcsclite.h.in (+1 -1), winscard.h (+1 -1)

rousseau 2010-08-13 15:19 #26 Rev.: 5130

Also call SCardDisconnect() and SCardReleaseContext() in the forked
process

27 lines of code changed in 1 file:

• UnitaryTests: SCard_fork.py (+27)

rousseau 2010-08-13 15:18 #25 Rev.: 5129

ContextThread(): goto exit if MSGCheckHandleAssociation() fails instead
of just returning no error.

Something wrong happened on the client side (like a fork) and the client
needs to call SCardEstablishContext() to create a new connection.

44 lines of code changed in 1 file:

• src: winscard_svc.c (+44 -51)

rousseau 2010-08-13 15:06 #24 Rev.: 5128

ContextThread(): fix goto label when it _is_ an overflow

2 lines of code changed in 1 file:

• src: winscard_svc.c (+2 -2)

rousseau 2010-08-13 15:01 #23 Rev.: 5127

ContextThread(): fix goto label when it is not an overflow

1 lines of code changed in 1 file:

• src: winscard_svc.c (+1 -1)

rousseau 2010-08-13 14:41 #22 Rev.: 5126

Revert changeset 5102 to add profiling on the client side again.

ltrace(1) can't be used with a dynamically loaded (dlopen(3)) library like
it is the case with the majority of PKCS#11 client application.

172 lines of code changed in 1 file:

• src: winscard_clnt.c (+172)

rousseau 2010-08-13 13:53 #21 Rev.: 5125

Reset mid field when the list is empty to avoid assert() errors

6 lines of code changed in 1 file:

• src: simclist.c (+6 -1)

rousseau 2010-08-13 13:51 #20 Rev.: 5124

MSGCheckHandleAssociation(): check that the context handle is still
valid. Calling a PC/SC function after SCardReleaseContext() is not
supported.

9 lines of code changed in 1 file:

• src: winscard_svc.c (+9)

rousseau 2010-08-13 12:09 #19 Rev.: 5123

Fix typo in comment

1 lines of code changed in 1 file:

• src: eventhandler.c (+1 -1)

rousseau 2010-08-05 17:16 #18 Rev.: 5118

remove debug line

0 lines of code changed in 1 file:

• configure.in (-2)

rousseau 2010-08-05 17:13 #17 Rev.: 5117

"/reader.conf.d" is only appended to sysconfdir if no value of
sysconfdir is provided

Thanks to Patrice Angelini for the bug report

12 lines of code changed in 1 file:

• configure.in (+12 -4)

rousseau 2010-08-05 10:02 #16 Rev.: 5114

HPAddHotPluggable(): do not use libusb_strerror() since it is not yet
available in current stable libusb (1.0.8)

3 lines of code changed in 1 file:

• src: hotplug_libusb.c (+3 -4)

rousseau 2010-08-05 09:51 #15 Rev.: 5113

Fix compilation warnings
ifdwrapper.c:166:7: warning: "IFDHANDLERv2" is not defined
ifdwrapper.c:589:7: warning: "IFDHANDLERv2" is not defined
ifdwrapper.c:640:7: warning: "IFDHANDLERv3" is not defined

3 lines of code changed in 1 file:

• src: ifdwrapper.c (+3 -3)

rousseau 2010-08-05 09:42 #14 Rev.: 5112

Check that either IFDHANDLERv1, IFDHANDLERv2 or IFDHANDLERv3 is
defined if PCSCLITE_STATIC_DRIVER is used

8 lines of code changed in 1 file:

• src: ifdwrapper.c (+8)

rousseau 2010-08-05 09:28 #13 Rev.: 5111

No need to use -D_REENTRANT. It was needed for LinuxThreads but we do
not use LinuxThreads since a long time.

See Debian bug #475101 "Remove obsolete -D_REENTRANT requirement"

0 lines of code changed in 1 file:

• c.sh (-2)

rousseau 2010-08-04 09:35 #12 Rev.: 5107

release 1.6.2

23 lines of code changed in 2 files:

• ChangeLog (+22), configure.in (+1 -1)

rousseau 2010-08-04 09:29 #11 Rev.: 5106

Remove useless $(COREFOUNDATION) from libpcsclite_la_LIBADD
The library has no Mac OS X specific code.

1 lines of code changed in 1 file:

• src: Makefile.am (+1 -1)

rousseau 2010-08-04 09:23 #10 Rev.: 5105

Remove undefined $(LIBSMARTCARD) from libpcsclite_la_LIBADD

1 lines of code changed in 1 file:

• src: Makefile.am (+1 -2)

rousseau 2010-08-04 09:20 #9 Rev.: 5104

libpcsclite does not use dlopen() so no need to link with $(LIBDL)

1 lines of code changed in 1 file:

• src: Makefile.am (+1 -1)

rousseau 2010-08-03 11:34 #8 Rev.: 5102

Remove client side profiling since we can use ltrace(1) with better
results

0 lines of code changed in 1 file:

• src: winscard_clnt.c (-174)

rousseau 2010-08-03 08:53 #7 Rev.: 5098

Remove 2 debug traces

0 lines of code changed in 1 file:

• configure.in (-2)

rousseau 2010-08-02 16:42 #6 Rev.: 5097

Use "SCARD_IO_REQUEST *" instead of LPSCARD_IO_REQUEST
and "const SCARD_IO_REQUEST *" instead of "LPCSCARD_IO_REQUEST

Should make the code more easy to read

6 lines of code changed in 3 files:

• src: winscard.c (+2 -2), winscard_clnt.c (+2 -2)
• src/PCSC: winscard.h (+2 -2)

rousseau 2010-08-02 16:33 #5 Rev.: 5096

Use SCARD_READERSTATE instead of SCARD_READERSTATE_A

Remove definitions of SCARD_READERSTATE_A PSCARD_READERSTATE_A and
LPSCARD_READERSTATE_A types

9 lines of code changed in 7 files:

• doc/example: pcsc_demo.c (+1 -1)
• src: testpcsc.c (+1 -1), winscard.c (+1 -1), winscard_clnt.c (+3 -3)
• src/PCSC: pcsclite.h.in (+1 -4), winscard.h (+1 -1)
• src/utils: formaticc.c (+1 -1)

rousseau 2010-08-02 09:39 #4 Rev.: 5093

Use $libdir instead of $prefix/lib to set the default value of usbdropdir

" Fedora uses /usr/lib on 32 bit and /usr/lib64 on 64 bit multilib
platforms. "

Thanks to Kalev Lember for the idea.
http://archives.neohapsis.com/archives/dev/muscle/2010-q3/0108.html

5 lines of code changed in 1 file:

• configure.in (+5 -3)

rousseau 2010-08-02 08:56 #3 Rev.: 5092

sysconfdir=/etc by default if prefix=/usr so remove the --sysconfdir line

0 lines of code changed in 1 file:

• c.sh (-1)

rousseau 2010-08-02 08:54 #2 Rev.: 5091

Do not duplicate the reader index to avoids problems when I want to
change it.

22 lines of code changed in 6 files:

• UnitaryTests: SCardBeginTransaction_Disconnect.py (+3 -1), SCardConnect_DIRECT.py (+3 -1), SCardConnect_DIRECT2.py (+6 -5), SCardExclusiveBehaviour.py (+4 -3), SCardReconnect.py (+3 -2), reset_card.py (+3 -2)

rousseau 2010-08-01 12:58 #1 Rev.: 5082

Set sysconfdir to /etc if prefix=/usr

You should have a default working configuration only with --prefix=/usr

7 lines of code changed in 1 file:

• configure.in (+7)

July 2010 »