April 2010 Commit Log

Number of Commits:

28

Number of Active Developers:

1

rousseau 2010-04-29 16:50 #28 Rev.: 4906

#include <string.h> on plateform that have strlcpy() to avoid a warning
(Mac OS X and Android)

error.c: In function �pcsc_stringify_error�:
error.c:64: warning: implicit declaration of function �strlcpy�
error.c:64: warning: nested extern declaration of �strlcpy�

3 lines of code changed in 1 file:

• src: strlcpycat.h (+3 -1)

rousseau 2010-04-29 11:45 #27 Rev.: 4905

#include <pthread.h>

Declare pthread_mutex_* functions

1 lines of code changed in 1 file:

• src: hotplug_linux.c (+1)

rousseau 2010-04-29 11:41 #26 Rev.: 4904

#include "utils.h"

Fix
hotplug_linux.c:391: error: �THREAD_ATTR_DETACHED� undeclared (first use in this function)

1 lines of code changed in 1 file:

• src: hotplug_linux.c (+1)

rousseau 2010-04-29 11:39 #25 Rev.: 4903

HPEstablishUSBNotifications(): do not call RFReCheckReaderConf if
USE_SERIAL is defined. The function is not defined in this case.

2 lines of code changed in 1 file:

• src: hotplug_libusb.c (+2)

rousseau 2010-04-29 09:26 #24 Rev.: 4901

Add --disable-serial and --disable-usb options

--disable-serial removes support of /etc/reader.conf
gain: 8.0kB of .text (12%) and 160 bytes of .bss (4%) for pcscd

--disable-usb removes support of USB hotplug
gain: 9.7kB of .text (14%) and 960 bytes of .bss (23%) for pcscd

If you use both options (and use a static driver configuration)
gain: 17.7kB of .text (26%) and 1152 bytes of .bss (28%) for pcscd

48 lines of code changed in 5 files:

• configure.in (+22)
• src: Makefile.am (+14 -6), hotplug_libhal.c (+1 -1), pcscdaemon.c (+7 -1), readerfactory.c (+4)

rousseau 2010-04-29 09:20 #23 Rev.: 4900

Define a minimal pcsc_stringify_error() if NO_LOG is defined.
Only the error code in hex is displayed in this case.

Gain: 2kB of .text (10%) for libpcsclite

12 lines of code changed in 1 file:

• src: error.c (+12)

rousseau 2010-04-29 09:14 #22 Rev.: 4899

main(): fork() only in case of auto exit to not detach from the terminal
if launched in stand alone forground mode ("pcscd -fda" for example)

6 lines of code changed in 1 file:

• src: pcscdaemon.c (+6 -5)

rousseau 2010-04-22 15:35 #21 Rev.: 4889

main(): always fork() so that pcscd always return in --auto-exit mode
but do not close stdout yet since we may need to send logs

6 lines of code changed in 1 file:

• src: pcscdaemon.c (+6)

rousseau 2010-04-22 15:18 #20 Rev.: 4888

SCardEstablishContext(): call waitpid() to avoid having a defunct pcscd
process when pcscd is auto started by the client.

The process becomes defunct because pcscd calls daemon() and daemon()
does fork() and exit() in the father. The father death must then be
reclaimed by libpcsclite.

Thanks to Patrice Angelini for the bug report

5 lines of code changed in 1 file:

• src: winscard_clnt.c (+5)

rousseau 2010-04-18 14:17 #19 Rev.: 4885

Directly use pthread_mutex_* fucntions instead of using wrappers
Remove thread_unix.c and thread_generic.h now useless

161 lines of code changed in 14 files:

• src: Makefile.am (-3), eventhandler.c (+9 -9), hotplug_libhal.c (+8 -8), hotplug_libusb.c (+8 -7), hotplug_linux.c (+6 -6), ifdwrapper.c (+20 -18), pcscdaemon.c (-1), readerfactory.c (+34 -32), readerfactory.h (+2 -3), thread_generic.h (del), thread_unix.c (del), winscard.c (+11 -10), winscard_clnt.c (+39 -39), winscard_svc.c (+24 -23)

rousseau 2010-04-18 13:49 #18 Rev.: 4884

Use pthread_t instead of PCSCLITE_THREAD_T

7 lines of code changed in 7 files:

• src: hotplug_libhal.c (+1 -1), hotplug_libusb.c (+1 -1), hotplug_linux.c (+1 -1), hotplug_macosx.c (+1 -1), readerfactory.h (+1 -1), utils.c (+1 -1), winscard_svc.c (+1 -1)

rousseau 2010-04-18 13:48 #17 Rev.: 4883

move thread related definition from thread_generic.h to utils.h

7 lines of code changed in 2 files:

• src: thread_generic.h (-6), utils.h (+7 -1)

rousseau 2010-04-18 13:39 #16 Rev.: 4882

Directly use pthread_* instead of SYS_Thread* indirection

Move SYS_ThreadCreate in utils.c. This function is not just one
pthread_* call

44 lines of code changed in 10 files:

• src: eventhandler.c (+6 -6), hotplug_libhal.c (+1 -1), hotplug_libusb.c (+1 -1), hotplug_linux.c (+1 -1), hotplug_macosx.c (+2 -2), thread_generic.h (-9), thread_unix.c (-61), utils.c (+26), utils.h (+3), winscard_svc.c (+4 -4)

rousseau 2010-04-16 18:08 #15 Rev.: 4877

SYS_ThreadExit(): remove dead code

From Sun Studio CC
"thread_unix.c", line 108: warning: statement not reached

0 lines of code changed in 1 file:

• src: thread_unix.c (-1)

rousseau 2010-04-16 14:54 #14 Rev.: 4875

update versions of autotools used

3 lines of code changed in 1 file:

• bootstrap (+3 -3)

rousseau 2010-04-15 21:12 #13 Rev.: 4874

remove ; at end of a { } block defined by a macro. The Solaris compiler
complains with:
"simclist.c", line 1317: warning: syntax error: empty declaration

Thanks to J�rg Schilling for the bug report

30 lines of code changed in 1 file:

• src: simclist.c (+30 -30)

rousseau 2010-04-15 21:08 #12 Rev.: 4873

use fork(), close() and chdir() instead of SYS_Fork(), SYS_CloseFile()
and SYS_Chdir() in SYS_Daemon() if HAVE_DAEMON is not defined (Solaris)

Thanks to J�rg Schilling for the bug report

13 lines of code changed in 1 file:

• src: sys_unix.c (+13 -20)

rousseau 2010-04-09 10:18 #11 Rev.: 4867

Log the command return code using DEBUG (SCARD_S_SUCCESS) or ERROR
(every thing else) level

4 lines of code changed in 1 file:

• src: winscard_svc.c (+4 -1)

rousseau 2010-04-08 17:36 #10 Rev.: 4866

reset a card using SCardDisconnect (default) or SCardReconnect (if an
argument is passed)

59 lines of code changed in 1 file:

• UnitaryTests: reset_card.py (new 59)

rousseau 2010-04-08 17:35 #9 Rev.: 4865

call SCardTransmit in an endless loop

36 lines of code changed in 1 file:

• UnitaryTests: transmit_loop.py (new 36)

rousseau 2010-04-08 17:34 #8 Rev.: 4864

SCardReconnect(): mimic the code from SCardDisconnect() regarding card
event state notifications (changed in revision 4862).

44 lines of code changed in 1 file:

• src: winscard.c (+44 -77)

rousseau 2010-04-08 17:14 #7 Rev.: 4863

no more pcsc_demo target

1 lines of code changed in 1 file:

• UnitaryTests: Makefile (+1 -2)

rousseau 2010-04-08 17:09 #6 Rev.: 4862

SCardDisconnect(): Set the card event state to SCARD_RESET _before_ doing
the reset.

This will avoid an SCardTransmit from another application between the
card reset and the card event state change. In the problematic case the
SCardTransmit was sending an APDU in T=1 to a reseted card but not yet
configured (IFDHSetProtocolParameters was not yet called) and still in
T=0 (default)

5 lines of code changed in 1 file:

• src: winscard.c (+5 -5)

rousseau 2010-04-08 15:51 #5 Rev.: 4861

SCardConnect() & SCardReconnect(): correctly log SCARD_PROTOCOL_RAW
protocol instead of "unknown"

32 lines of code changed in 1 file:

• src: winscard.c (+32 -14)

rousseau 2010-04-07 17:08 #4 Rev.: 4859

Fix copyright name and date

4 lines of code changed in 2 files:

• src: winscard_msg.c (+2 -2), winscard_msg_srv.c (+2 -2)

rousseau 2010-04-07 17:06 #3 Rev.: 4858

Doxygen: document SHMMessageReceive() command argument added in revision 4718

1 lines of code changed in 1 file:

• src: winscard_msg.c (+1)

rousseau 2010-04-07 17:01 #2 Rev.: 4857

Doxygen: SCARD_ATTR_DEVICE_FRIENDLY_NAME is implemented by
SCardGetAttrib() if the IFD Handler (driver) returns IFD_ERROR_TAG.
pcsc-lite then returns the same reader name as returned by
SCardListReaders.

4 lines of code changed in 1 file:

• src: winscard_clnt.c (+4 -1)

rousseau 2010-04-01 09:09 #1 Rev.: 4851

Add PCSCv2_PART10_PROPERTY_* defines

10 lines of code changed in 1 file:

• src/PCSC: reader.h.in (+10)

March 2010 »