January 2009 Commit Log

Number of Commits:

36

Number of Active Developers:

1

rousseau 2009-01-29 18:08 #36 Rev.: 3295

RFLockSharing() & RFUnlockSharing(): add a mutex to avoid a race
condition

Closes: [#311377] Race condition in SCardBeginTransaction

17 lines of code changed in 1 file:

• src: readerfactory.c (+17 -12)

rousseau 2009-01-28 15:34 #35 Rev.: 3294

log TxBuffer and RxBuffer if the SCardControl() command failed.

Closes: [#311376] PCSC_LOG_VERBOSE via -dd; print details of "Card not
transacted"

6 lines of code changed in 1 file:

• src: ifdwrapper.c (+6)

rousseau 2009-01-24 14:46 #34 Rev.: 3291

StatSynchronizeContext() is used for a specific client. Correct the
comment.

2 lines of code changed in 1 file:

• src: utils.c (+2 -2)

rousseau 2009-01-22 15:54 #33 Rev.: 3290

mark IFD_GENERATE_HOTPLUG as deprecated.
HAL now solves the hotplug problem for us.

6 lines of code changed in 1 file:

• doc: ifdhandler-3.tex (+6 -1)

rousseau 2009-01-20 17:18 #32 Rev.: 3288

SCardCancel(): use StatSynchronizeContext() to send an event to the
waiting/blocked thread

Closes: [#311342] SCardCancel does not cancel an outstanding SCardGetStatusChange

6 lines of code changed in 1 file:

• src: winscard_clnt.c (+6 -2)

rousseau 2009-01-20 17:16 #31 Rev.: 3287

add StatSynchronizeContext() to send an asynchronous event to a specific
context
This function can be used from libpcsclite. Using StatSynchronize() does
not work since the directory pcscd.events/ is not readable by group and
other for security reasons

40 lines of code changed in 2 files:

• src: utils.c (+39), utils.h (+1)

rousseau 2009-01-20 17:14 #30 Rev.: 3286

WaitForPcscdEvent(): use hContext instead of a random to name the event
file

5 lines of code changed in 1 file:

• src: winscard_clnt.c (+5 -5)

rousseau 2009-01-20 17:00 #29 Rev.: 3285

improved version

9 lines of code changed in 1 file:

• UnitaryTests: SCardCancel.py (+9 -10)

rousseau 2009-01-13 21:25 #28 Rev.: 3279

SCardCancel sample

45 lines of code changed in 1 file:

• UnitaryTests: SCardCancel.py (new 45)

rousseau 2009-01-13 16:42 #27 Rev.: 3278

SCardGetStatusChange(): return if the state of the reader changed since the
previous call.

Thanks to Thomas Harning for the patch
Closes: [#311341] SCardGetStatusChange does not return CHANGED+EMPTY and
CHANGED+PRESENT sequence for remove-insert between calls

3 lines of code changed in 1 file:

• src: winscard_clnt.c (+3)

rousseau 2009-01-12 10:22 #26 Rev.: 3277

test SCardGetStatusChange

125 lines of code changed in 2 files:

• UnitaryTests/SCardGetStatusChange: SCardGetStatusChange.py (new 50), SCardGetStatusChange_PnP.py (new 75)

rousseau 2009-01-09 18:50 #25 Rev.: 3274

rename variable fd in profile_fd to avoid
winscard_clnt.c:1717: attention : declaration of �fd� shadows a global declaration

6 lines of code changed in 1 file:

• src: winscard_clnt.c (+6 -6)

rousseau 2009-01-07 22:28 #24 Rev.: 3273

release 1.5.1

10 lines of code changed in 2 files:

• ChangeLog (+9), configure.in (+1 -1)

rousseau 2009-01-05 15:58 #23 Rev.: 3267

use offsetof(transmit_struct_extended, data) instead of sizeof(*treStr) since
from revision 2146 the data[] array has one element to be compilable by Sun
Studio 11

The side effect is that extended APDU were corrupted by 4 zero bytes between the two consecutive blocks

6 lines of code changed in 1 file:

• src: winscard_svc.c (+6 -5)

rousseau 2009-01-05 12:54 #22 Rev.: 3266

use snprintf() to avoid a possible buffer overflow

2 lines of code changed in 1 file:

• src: readerfactory.c (+2 -1)

rousseau 2009-01-05 12:43 #21 Rev.: 3265

avoid a memory leak in case of DBus error

4 lines of code changed in 1 file:

• src: hotplug_libhal.c (+4 -4)

rousseau 2009-01-05 12:35 #20 Rev.: 3264

script to call splint

17 lines of code changed in 1 file:

• splint.sh (new 17)

rousseau 2009-01-05 12:29 #19 Rev.: 3263

explicitly cast result in void when not used (reported by the splint tool)

23 lines of code changed in 1 file:

• src: pcscdaemon.c (+23 -23)

rousseau 2009-01-05 12:19 #18 Rev.: 3262

free mszReaders before returning

4 lines of code changed in 1 file:

• src/utils: formaticc.c (+4)

rousseau 2009-01-05 12:14 #17 Rev.: 3261

do not cast malloc()

1 lines of code changed in 1 file:

• src/utils: formaticc.c (+1 -1)

rousseau 2009-01-02 17:19 #16 Rev.: 3260

tag output parameters with /*@out@*/

52 lines of code changed in 12 files:

• src: atrhandler.h (+1 -1), configfile.h (+2 -1), dyn_generic.h (+1 -1), ifdwrapper.c (+7 -6), ifdwrapper.h (+7 -5), parser.h (+1 -1), readerfactory.h (+3 -3), sys_generic.h (+2 -2), winscard_clnt.c (+6 -3), winscard_msg.h (+3 -3), winscard_msg_srv.c (+1 -1)
• src/PCSC: winscard.h (+18 -14)

rousseau 2009-01-02 16:32 #15 Rev.: 3259

tag potentially NULL paramater or returned value as /*@null@*/

18 lines of code changed in 6 files:

• src: eventhandler.h (+2 -1), hotplug_libhal.c (+2 -1), sys_unix.c (+1 -1), thread_generic.h (+4 -3), utils.h (+1 -1)
• src/PCSC: winscard.h (+8 -7)

rousseau 2009-01-02 16:08 #14 Rev.: 3258

declare functions static where possible

13 lines of code changed in 1 file:

• src: pcscdaemon.c (+13 -14)

rousseau 2009-01-02 16:06 #13 Rev.: 3257

remove unused SVCClientCleanup() function

0 lines of code changed in 1 file:

• src: pcscdaemon.c (-11)

rousseau 2009-01-02 16:04 #12 Rev.: 3256

mark unused parameter as /*@unused@*/ (reported by splint tool)

3 lines of code changed in 1 file:

• src: pcscdaemon.c (+3 -3)

rousseau 2009-01-02 16:02 #11 Rev.: 3255

no need to #include <syslog.h>

0 lines of code changed in 1 file:

• src: pcscdaemon.c (-1)

rousseau 2009-01-02 16:01 #10 Rev.: 3254

not need to #include <syslog.h>

0 lines of code changed in 1 file:

• src: atrhandler.c (-1)

rousseau 2009-01-02 16:01 #9 Rev.: 3253

declare functions static where possible

19 lines of code changed in 3 files:

• src: eventhandler.c (+2 -2), testpcsc.c (+1 -2), winscard_svc.c (+16 -14)

rousseau 2009-01-02 15:49 #8 Rev.: 3252

mark unused parameter as /*@unused@*/ (reported by splint tool)

27 lines of code changed in 9 files:

• src: hotplug_libhal.c (+1 -1), pcsc-wirecheck-gen.c (+1 -1), pcsc-wirecheck-main.c (+1 -1), readerfactory.c (+1 -1), testpcsc.c (+1 -1), winscard.c (+14 -9), winscard_clnt.c (+6 -4)
• src/utils: formaticc.c (+1 -1), installifd.c (+1 -1)

rousseau 2009-01-02 15:39 #7 Rev.: 3251

remove blocktime parameter from SHMProcessEventsContext() and SHMProcessEventsServer() since this parameter is not used

6 lines of code changed in 4 files:

• src: pcscdaemon.c (+1 -1), winscard_msg.h (+2 -2), winscard_msg_srv.c (+2 -3), winscard_svc.c (+1 -1)

rousseau 2009-01-02 15:32 #6 Rev.: 3250

correct return types of SHMMessageSend() and SHMMessageReceive() to match declaration in winscard_msg.h (reported by splint tool)

2 lines of code changed in 1 file:

• src: winscard_msg.c (+2 -2)

rousseau 2009-01-02 15:30 #5 Rev.: 3249

SHMInitializeCommonSegment(): use correct return type as defined in winscard_msg.h (reported by splint tool)

1 lines of code changed in 1 file:

• src: winscard_msg_srv.c (+1 -1)

rousseau 2009-01-02 15:28 #4 Rev.: 3248

reformat

7 lines of code changed in 1 file:

• src: readerfactory.c (+7 -7)

rousseau 2009-01-02 15:22 #3 Rev.: 3247

explicitly cast result in void when not used (reported by the splint tool)

341 lines of code changed in 20 files:

• src: configfile.l (+4 -4), debug.c (+2 -2), dyn_unix.c (+1 -1), error.c (+39 -39), eventhandler.c (+15 -15), hotplug_libhal.c (+15 -15), ifdwrapper.c (+33 -33), readerfactory.c (+30 -29), sys_unix.c (+1 -1), testpcsc.c (+9 -9), thread_unix.c (+1 -1), tokenparser.l (+8 -8), utils.c (+8 -8), winscard.c (+30 -30), winscard_clnt.c (+99 -99), winscard_msg.c (+5 -5), winscard_msg_srv.c (+4 -4), winscard_svc.c (+12 -11)
• src/utils: formaticc.c (+22 -22), installifd.c (+3 -3)

rousseau 2009-01-02 12:49 #2 Rev.: 3246

CFLAGS is now defined in ~/.bash_profile

3 lines of code changed in 1 file:

• c.sh (+3 -4)

rousseau 2009-01-02 12:45 #1 Rev.: 3245

SYS_RandomInt(): replace a cast to (float) by an explicit conversion using +0.0

1 lines of code changed in 1 file:

• src: sys_unix.c (+1 -1)

December 2008 »